search

FAIRmat-NFDI / data-modeling

3 stars 1 forks source link

Dataconverter writes "1.0" as a float to the NX_CHAR attribute NXentry/definition/version #53

Open RubelMozumder opened 1 year ago

RubelMozumder commented 1 year ago

This are multiple points I think:

  1. Parsing nexus to metainfo fails in nomad if an attributes contains a float value.
  2. There are some files written in the past which should contain a float instead of a NX_CHAR (e.g. example file of arpes for /data/@...indices)
  3. In my opinion the parser should just check the type of the value provided vs the definition and fail if they do not match. Currently, we have a semi-validating parser which could give the wrong impression that your file is correct if it gets parsed.
RubelMozumder commented 1 year ago

Bug is fixed but, now the xps-jupyter container does not get the path for uploaded xps files in nomad.

RubelMozumder commented 1 year ago

Done!