search

FAIRmat-NFDI / data-modeling

3 stars 1 forks source link

Ellips angular spread unit is radian**2
ELN accepts, but parser claims it being incompatible unit for ANGLE #58

Closed sanbrock closed 1 year ago

sanbrock commented 1 year ago

I think there was also some gui issue for the value being present in pint but not in the unit registry we use in the gui system (We may have used steradian in the past and I may have changed it to radian**2). I don't really know the issue in detail but from just the text being written I would also say that reject radian**2 as an ANGLE is correct, radian is a unit of angle and radian**2 is a unit of solid angle / steradian.

domna commented 1 year ago

I get a second error while parsing this file:

The shape of nexus.NXellipsometry.NXentry.NXsample.column_names__field:
Quantity requires an iterable value, but ['psi' 'delta'] is not iterable.

For the angular_spread I think we just have to change the value to radian in the eln, as I would say that the angular spread is typically measured in an angle. If we wanted to use steradian I think a naming of solid angle would be better. @csturmUL What do you think?

domna commented 1 year ago

I changed to unit to radian in the eln in north/dev and updated it in the sprint branch. If we have any objections that this value has unit radian we have to revert it.