FAIRmat-NFDI / data-modeling

3 stars 1 forks source link

Collaboration request Tilmann and team, Add NXms example for 2D and 3D grain segmentation based on existent work from Markus for exporting from Matlab/MTex and DREAM.3D #98

Open mkuehbach opened 1 year ago

mkuehbach commented 1 year ago

Aim/Expectation: Finish the implementation of an example how our NeXus machinery and tools can be used for topics relevant in MatWerk (contact person interested in reviewing and trying to check if they can apply (at least partly) what we have developed: Tilmann Hickel, Eric Bitzek

mkuehbach commented 1 year ago

@sanbrock most of the pre1 refactoring for appdefs and base classes has been done for apm, em, and bridge_to_matwerk thats why I put this already in review, the respective branch is a PR for the fairmat-apm-em-matwerk-pre1 to become merged into the fairmat branch in the nexus_definitions repo, I have also edited the structure.rst files and prepared one for stm for Rubel and you to fill in.

Please do NOT yet merge the PR as I expect some changes to come when I now fix the readers.

mkuehbach commented 1 year ago

When comparing the XML files to those in the fairmat branch there are de facto changes also which come from a changed processing of the nyaml2nxdl parser these changes are e.g. that NX_CHAR is dropped and comments from the yaml are carried over into the NXDL file, as I am not sure if we all agree that this is what should happen and if this is convertable also from NXDL to YAML I have not yet updated all NXDL files but the YAML files already in this PR and branch, clarification on Mo is useful