Use NXresolution in MPES

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents

https://manual.nexusformat.org/

Other

5 stars 8 forks source link

Use NXresolution in MPES #124

Closed lukaspie closed 6 months ago

lukaspie commented 7 months ago

[X] Always use NXresolution base class instead of NX_FLOAT
[x] open question: do we want to keep the specific resolution names (i.e, energy_resolution, momentum_resolution) in the NXinstrument and NXelectronanalyser? Or do we just have one (NXresolution) in the base class and define the different types of resultion only on the AppDef level? I would argue for the first option because it shortens the AppDef and makes it more readable.
[x] Make NXDL with new nyaml2nxdl

domna commented 7 months ago

[x] open question: do we want to keep the specific resolution names (i.e, energy_resolution, momentum_resolution) in the NXinstrument and NXelectronanalyser? Or do we just have one (NXresolution) in the base class and define the different types of resultion only on the AppDef level? I would argue for the first option because it shortens the AppDef and makes it more readable.

+1 for the first option because this makes it also aligned if we use it somewhere else, too

lukaspie commented 7 months ago

@rettigl are you fine with keeping the resolutions in the base classes? If so, are you okay with merging this PR? Thanks!