search

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
5 stars 8 forks source link

EM refactoring / EMv2 #136

Closed mkuehbach closed 4 months ago

mkuehbach commented 6 months ago

Before this PR can be merged #140 has to be merged in and nyaml2nxdl should be run again over all NXDL files to get consistent dates, thereafter remaining issues with make local have to be fixed.

However, none of these limitations block the reviewing of the changes and conceptual edits in the classes of this PR.

mkuehbach commented 4 months ago

In the future offsprings for NXem should inherit from the NXem appdef i.e.

NXem_offspring(NXem)

sanbrock commented 4 months ago

also after cleanup of nxdl files, nyaml representation can be removed from the repository

mkuehbach commented 4 months ago

Please not again this discussion about removing or not yaml files - especially not with a disfunctional converter - I do not support removing them. Remove them with the last commit that one commits prior to a merging of fairmat states into official NIAC branches that i agree.