APM refactoring / APMv2

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents

https://manual.nexusformat.org/

Other

5 stars 8 forks source link

APM refactoring / APMv2 #140

Closed mkuehbach closed 4 months ago

mkuehbach commented 6 months ago

Bridging between atom probe measurement and simulation
Align better with concept of event_data for EM
Restructured constraints based on feedback from Cameca and feedback obtained from assessment of RHIT file structure and content therein
pynxtools allow parsing of hitherto unsupported formats (ENV, ATO, FAU/Erlangen pyccapt)
Base class inheritance

lukaspie commented 5 months ago

Please note that with #157, some unneeded fields are planned to be removed from the NXsource base class. I carefully checked that these fields are not used here or in EM. In addition, I have added wavelength to the NXsource base class, which is used here in NXapm, but was not part of the base class before.

We can discuss in that PR which fields should be added/removed.

lukaspie commented 4 months ago

LGTM, all my conversations are resolved. If @sanbrock is happy, please go ahead with the merge.