Make generic NXhistory, add NXhistory in NXinstrument (for instrument preparation)

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents

https://manual.nexusformat.org/

Other

6 stars 8 forks source link

Make generic NXhistory, add NXhistory in NXinstrument (for instrument preparation) #177

Closed lukaspie closed 7 months ago

lukaspie commented 7 months ago

[x] Rename NXsample_history to NXhistory to describe history of any physical entity
[x] Use NXhistory in NXsample
[x] Use instrument history in MPES

NOTE: This PR depends on #74. The instrument and sample history have been moved from NXmpes to NXphotoemission.

Resolves #174.

lukaspie commented 7 months ago

I have rebased here to #74 and now the PR points there as well. The histories are now part of NXphotoemission, but NXmpesis also still here. We can merge this PR before merging the other one.

lukaspie commented 7 months ago

Regarding the use of NXhistory, see also my comment here.

lukaspie commented 7 months ago

My suggestion: we merge this as it is (with the narrow scope of photoemission) and then we can come back later to the interplay of NXhistory, NXactivity, NXprocess and the various existing NXgraph_*.

EDIT: I created an issue for this: #181. @mkuehbach would you be fine with discussion there and/or in a new PR and merge this PR as is?