search

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
5 stars 8 forks source link

Update appdef for nxsts #182

Closed RubelMozumder closed 2 months ago

RubelMozumder commented 4 months ago

Bringing all the plots like single_points and line_scan on the same level and out of the NXdata group.

RubelMozumder commented 2 months ago

The only remaining point is the ambiguity of the too many options where and how 'version' and model name can be registered in NXfabrication.

RubelMozumder commented 2 months ago

@sanbrock Sorry do not be confused seeing still old version of appdef. Trying the ci/cd why it is failed?

RubelMozumder commented 2 months ago

@sanbrock I do not know why ci/cd failed. I have to check it. If you agree with the change please resolve the issue then I can start with the reader update respecting the new version of the PR.

RubelMozumder commented 2 months ago

@mkuehbach, @domna, and @lukaspie, in the Fabrication I have extended mode field by a new version attribute. Mainly, each model there may have several versions such as 5e and 4.5 from generic model. Do you see any conflict with this little change with your existing application definition?

lukaspie commented 2 months ago

@mkuehbach, @domna, and @lukaspie, in the Fabrication I have extended mode field by a new version attribute. Mainly, each model there may have several versions such as 5e and 4.5 from generic model. Do you see any conflict with this little change with your existing application definition?

Should be fine from the MPES side.

RubelMozumder commented 2 months ago

@mkuehbach, @domna, and @lukaspie, in the Fabrication I have extended mode field by a new version attribute. Mainly, each model there may have several versions such as 5e and 4.5 from generic model. Do you see any conflict with this little change with your existing application definition?

Should be fine from the MPES side.

Thanks for your quick reply.

RubelMozumder commented 2 months ago

Hi @RubelMozumder,

The concept model is an arbitrary tech-partner specific brand name, I support that the docstring should be changed in that "when there is ambiguity about which model (version) we are talking one should write the model version in "model", I would not make an own attribute version here an example Nion microscope Hermes 100 versus Hermes 200 I would write better the docstring such that people should users write either of these versions but not just "Hermes" into model, therefore use this docstring: "Model of the component as it is named by the manufacturer. If different versions exist are possible, the value in this field should be made specific enough to resolve the version."

Rest of the PR looks good to me

Done!

RubelMozumder commented 2 months ago

@sanbrock, now it can be approved to be merged.