search

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
5 stars 8 forks source link

fix for NXbeam... #191

Closed sanbrock closed 4 months ago

sanbrock commented 4 months ago

While the order is irrelevant for nyaml tool, the nxdl specification requires the dimensions to be declared before any attributes.

lukaspie commented 4 months ago

I cannot find that specification in the nxdl.xsd. Is it just how the things are ordered here? If the order of these things ist important, shouldn't our tool sort them automatically?

sanbrock commented 4 months ago

The elements are in a sequence which means in an ordered list. In fact, the nyaml could take care of it which could be a new nice convenience feature.

lukaspie commented 4 months ago

Ok, I'll add an issue in the nyaml repo. I don't think all of our definitions currently respect this ordering.

sanbrock commented 4 months ago

Thanks! xsd validation is executed during documentation generation, so similar problems should have been highlighted by CI/CD if they were present as this inconsistency was indeed breaking the CI/CD in this case, too.

lukaspie commented 4 months ago

Okay, then maybe the other definitions were correctly ordered "by accident". Anyway, the tool should do this automatically.

RonHildebrandt commented 4 months ago

Okay, order matters. Sounds good.