Overhaul of NXopt - Githubissues

RonHildebrandt commented 2 months ago

This PR is a full rework of the NXopt definition. The for this was used from NXmpes and NXem.

NXopt was first defined from NXellipsometry. Therefore, some concepts are present in the current NXopt form, which makes sense to define NXellipsometry(NXopt), but not for e.g. NXraman(NXopt) or NXpl(NXopt). This rework should generalize NXopt in a first step, before in an upcoming workshop final refinements are done.

Added/Modified Parts:

General entry information
Various NXuser fields
Various instrument Devices
Reference frames with description (needs to be worked out later in detail)
Added two additional fundamental angles required for scattering/emission experiments and sample rotation
moved/added calibration and exp. resolution
NXbeams with polarization description
Specified NXsource and NXdetector similar to NXmpes
Moved sample medium opt. prop. to NXinstrument
NXmanipulator as stage
NXsensor and NXactuator with specific examples for temperature
Sample description was refined
(NXdata) replaces data_collection(NXprocess)
simple template for calibration data added similar to NXmpes

tl;dr: Full Overhaul of NXopt to enable the description of a generic optical experiment as well as specialization.

RonHildebrandt commented 2 months ago

Please also include an updated version of NXellipsometry so it is compatible with the new NXopt. Also, please add NXraman, too.

All right, then PR201 can be closed I think and Ill move everything to this PR including updating NXraman and adjusting NXellipsometry accordingly.

sanbrock commented 2 months ago

Or this NXopt can be moved there. The point is that NXellipsometry is using (inheriting from) NXopt, so we should ensure that NXellipsometry in every version of the repository is compatoble with NXopt and its actual update. The same applies to NXraman.

RonHildebrandt commented 2 months ago

Or this NXopt can be moved there. The point is that NXellipsometry is using (inheriting from) NXopt, so we should ensure that NXellipsometry in every version of the repository is compatoble with NXopt and its actual update. The same applies to NXraman.

Ah okay, makes sense.

RonHildebrandt commented 2 months ago

I considered all comments from @lukaspie . Many of them I may adress at a later stage, as they are in my opinion not critical. Ill added a todo-list for that in the file as comment.

RonHildebrandt commented 2 months ago

Thanks for taking a look into this @tomio13 . Required modification will be included in the next commit.

FAIRmat-NFDI / nexus_definitions

Overhaul of NXopt #220