search

FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
6 stars 8 forks source link

Plan for SPM app def. #241

Open RubelMozumder opened 3 months ago

RubelMozumder commented 3 months ago
RubelMozumder commented 3 months ago

These are the things I saw immediately when going through the file, there will probably be more review in the future.

Thanks for your spontaneous review. I will take care of them.

RubelMozumder commented 3 months ago

@lukaspie can you go through the other files in this PR. Mainly, I would suggest to check the structure and concept such as units, dimensionality and so on. Still some of the text from old version so sometime they are explained not correctly.

RubelMozumder commented 3 months ago

@lukaspie I am leaving all the change requests for NXspm resolved. This is not the part of this scrum, for now we are considering only base classes. But, definitely when I use the base classes in the NXspm and modify that we need a full review on it.

Note: I have also restructure NXbias_spectroscopy, probably you did not find some of the fields. Just not to be confused.

lukaspie commented 3 months ago

@lukaspie I am leaving all the change requests for NXspm resolved. This is not the part of this scrum, for now we are considering only base classes. But, definitely when I use the base classes in the NXspm and modify that we need a full review on it.

I don't understand this. Why is NXspm changed here at all then? If it's not to be addressed here, I would suggest to remove any changes on NXspm in this PR. Otherwise, at least leave a comment in the yaml file so that these comments here don't get lost.

RubelMozumder commented 3 months ago

SPM application definition for (STM, STS and AFM) is being handled here #259