FAIRmat-NFDI / nexus_definitions

Definitions of the NeXus Standard File Structure and Contents
https://manual.nexusformat.org/
Other
6 stars 8 forks source link

#243 Sprint22 Add stigmation correctors, removed unnecessary EM-Base Classes, opened NXcomponent for other techniques #250

Closed mkuehbach closed 2 months ago

mkuehbach commented 2 months ago

This PR is ready to get merged into fairmat.

However, it introduces breaking changes in the data model of some em examples which requires feature updates and fixes to be made in pynxtools-em. Currently, there is vacation time, a basesection sprint is planned to happen right after the vacation time, which should then get all the focus. In summary, there is now a two week gap in which the changes for em can be implemented without introducing breaking changes on the main development line.

Therefore, I will close this PR and merge sprint22_corrector into sprint23_em_v3. This branch is a clone of today's fairmat branch such that it can be used to implement and test a specific pynxtools definition version instead of the mainline fairmat. This avoids breaking examples, enables to use the two week gap for an EM sprint.

An additional advantage is that also sprint22_microstructure can be merged into sprint23_em_v3 such that the entire package of em and microstructure description related changes can be used in the same pynxtools development. This is relevant because also feature additions of the MTex exporting is planned that require sprint22_microstructure.