FAIRmat-NFDI / nomad-analysis

This repo contains the standard NOMAD plugin for analysis.
https://fairmat-nfdi.github.io/nomad-analysis/
Apache License 2.0
1 stars 0 forks source link

Refer all entries belonging to a certain class #8

Closed ka-sarthak closed 4 months ago

ka-sarthak commented 4 months ago

For large data analysis, like ML applications, one might want to add input references to large number of entries. Currently, to do this, they have to add each input reference individually.

Make a quantity that asks for an entry class and collects all the available entries of that class. These entries are then attached to the input.

@aalbino2 Does this makes sense? Please add your suggestions or comments.

aalbino2 commented 4 months ago

Would this be a new kind of quantity or just a string that you then process in some normalize function with some API query?

ka-sarthak commented 4 months ago

@aalbino2 I am thinking of just a string for now. But it will great if we can make a drop down selection (Enum) which gets updated based on what Entry classes are available to the user. I don't know if it's possible with current EditQuantities.

The implementation can be broadly divided into two parts:

We can start with a StringEditQuantity for the first part and improve later. In the meantime, i will set up the API calls and also make a feature request for an appropriate selection Edit Quantity.

aalbino2 commented 4 months ago

I see. The new quantity idea is not bad! Let's see if it can be designed in a general enough way to be worth the implementation

Thanks, in any case this issue targets my needs for the prototype ipynb file we were discussing.

Go ahead! 👍🏼