FAIRmat-NFDI / nomad-material-processing

A NOMAD plugin containing base sections for material processing.
https://fairmat-nfdi.github.io/nomad-material-processing/
Apache License 2.0
9 stars 2 forks source link

generated vapor deposition module #31

Closed aalbino2 closed 9 months ago

aalbino2 commented 9 months ago

@hampusnasstrom this are the classes I would like to leverage in this MR to the more general module. If you agree to this rough draft, I will keep refining and then you can review more in detail

aalbino2 commented 9 months ago

I basically removed the "P" everywhere, I will then take care of generating a CVD module, too. And also fix all the importings

aalbino2 commented 9 months ago

todos:

aalbino2 commented 9 months ago

In the last commit, I changed the thinfilmstack class. I need to discuss this together @hampusnasstrom

aalbino2 commented 9 months ago

hey @hampusnasstrom, I propose a small change that is the following: the vapor_deposition_step > sample_parameters > process_time array should live directly inside vapor_deposition_step because, even if you have multiple substrates, the process will last the same time for each of them. Is this true?

    process_time = Quantity(
        type=float,
        unit="second",
        shape=["*"],
    )
hampusnasstrom commented 9 months ago

hey @hampusnasstrom, I propose a small change that is the following: the vapor_deposition_step > sample_parameters > process_time array should live directly inside vapor_deposition_step because, even if you have multiple substrates, the process will last the same time for each of them. Is this true?

    process_time = Quantity(
        type=float,
        unit="second",
        shape=["*"],
    )

I'm not sure if this is always the case. For most people yes, but for most people all the process_time quantities in the whole schema are the same. I would say we just stay consistent with the rest of the schema and always store the process_time right next to the values for now. We definitely need to talk to Area D about having a option to reference these all to one array though!

aalbino2 commented 9 months ago

@hampusnasstrom I have a question: why do GasFlow in the ChamberEnvironment class is a repeated section? Isn't just one gas flow in the chamber? And if there are more flows, shouldn't they probably be placed directly into each Source class?

hampusnasstrom commented 9 months ago

@hampusnasstrom I have a question: why do GasFlow in the ChamberEnvironment class is a repeated section? Isn't just one gas flow in the chamber? And if there are more flows, shouldn't they probably be placed directly into each Source class?

There could be multiple flows of non participating gases. For example, the PLD IKZ can have three gasses, N2, O2 and Ar.