Update and use TimeSeries section

FAIRmat-NFDI / nomad-material-processing

A NOMAD plugin containing base sections for material processing.

https://fairmat-nfdi.github.io/nomad-material-processing/

Apache License 2.0

9 stars 2 forks source link

Update and use TimeSeries section #37

Closed hampusnasstrom closed 7 months ago

aalbino2 commented 8 months ago

i pushed something in main earlier today, so I think you will need to rebase it

aalbino2 commented 8 months ago

As a side note to be evaluated in this PR, in the VaporDepositionSource there is a reference to material that is a CompositeSystemReference, I think we should make it a SystemComponent, in analogy to how we do in solution.

The use of CompositeSystemReference is indeed an artifact that allows us to indicate a mass (or in general the amount) of a component, but this creates a new CompositeSystem entry with actual no need.

we?ll discuss in data modeling meeting on 20.03.24

aalbino2 commented 7 months ago

it looks good for me, if you are also happy with that, we can merge!