FAIRmat-NFDI / nomad-measurements

A NOMAD plugin containing base sections for measurements.
https://FAIRmat-NFDI.github.io/nomad-measurements/
Apache License 2.0
14 stars 1 forks source link

Create a repo and a Pypi package for XRD reader #99

Closed aalbino2 closed 4 months ago

aalbino2 commented 5 months ago

Let'S clarify the best approach:

One repo with multiple PyPi packages or small repos for each reader ? ?

Pros: better git workflow with one repo for each Pypi package Cons: flooding the FAIRmat NFDI with a lot of repos for each reader

@hampusnasstrom @ka-sarthak I think we can discuss this in the next data modeling on wednesday

aalbino2 commented 5 months ago

name for the repo: reader-xrd

name for the module: fairmat_reader_xrd.py

name for Pypi package: fairmat-reader-xrd

ka-sarthak commented 5 months ago

@aalbino2 Sounds great, so should I wait until our meeting before creating the new repo?

aalbino2 commented 5 months ago

yes let's finalize on wednesday

hampusnasstrom commented 5 months ago

I would use hyphens instead of underscores but otherwise it sounds good. Yeah, let's do it on Wednesday.

ka-sarthak commented 5 months ago

Here's a PR to resolve this https://github.com/FAIRmat-NFDI/readers-xrd/pull/2