FAIRmat-NFDI / nomad-perovskite-solar-cells-database

A NOMAD plugin containing the schema for the Perovskite Solar Cell Database.
https://fairmat-nfdi.github.io/nomad-perovskite-solar-cells-database/
Apache License 2.0
3 stars 1 forks source link

feat: nomad perovskite solar cell schema plugin #2

Closed yaruwangway closed 11 months ago

yaruwangway commented 11 months ago

closes: #1 nomad schma is originally located in the nomad source code. This PR is to make a package of perovskite solar cell plugin. so that this schema code can be removed from the nomad app code.

Pepe-Marquez commented 11 months ago

@lauri-codes, can you please have a look at this?

We have migrated the perovskite database schemas in NOMAD to this plugin.

By doing so,

lauri-codes commented 11 months ago

Please also add the github actions workflow that runs the tests for each commit. You can copy the config from the example repo: https://github.com/nomad-coe/nomad-schema-plugin-example/tree/main/.github/workflows

yaruwangway commented 11 months ago

Please also add the github actions workflow that runs the tests for each commit. You can copy the config from the example repo: https://github.com/nomad-coe/nomad-schema-plugin-example/tree/main/.github/workflows

The action can not pass for now because:

  1. nomad.datamodel.metainfo.plot only exists in nomad develop branch, so i update pyproject.toml to use develop branch as a temporarily solution
  2. but the nomad develop branch does not change the yml file yet to include the perovskite_solar_cell package. so running test here will fail.

one solution might be to pull the nomad repo to the testing server, and change the nomad.yml in nomad repo locally and install local package nomad to perovskite-solar-cell database, like when we test locally. Otherwise, once this plugin is included in a nomad release, the test should work here.

lauri-codes commented 11 months ago
  1. nomad.datamodel.metainfo.plot only exists in nomad develop branch, so i update pyproject.toml to use develop branch as a temporarily solution

Sounds good.

  1. but the nomad develop branch does not change the yml file yet to include the perovskite_solar_cell package. so running test here will fail.

The main package does not need to include the plugin or the package, I think this is handled by the nomad.yaml file in this plugin repository, which is picked when you run the tests inside the main folder? But maybe I misunderstood the problem.