search

FAIRmat-NFDI / nomad-perovskite-solar-cells-database

A NOMAD plugin containing the schema for the Perovskite Solar Cell Database.
Apache License 2.0
2 stars 0 forks source link

feat: add ion #5

Closed yaruwangway closed 5 months ago

yaruwangway commented 7 months ago

closes: #4 Screenshot from 2024-03-21 16-30-55

Screenshot from 2024-03-21 16-32-34

Pepe-Marquez commented 5 months ago

@lauri-codes, can you have a look at this? The overall goal is to enhance the compositional data of the perovskites by leveraging the mapping tables of the ions used in the literature that Jesper compiled. I left some comments tagging you where needed.

@yaruwangway, I just realized that we possibly need to add some testing to this new normalization.

yaruwangway commented 5 months ago

@Pepe-Marquez tests added in test_schema.py if you can have a look. @lauri-codes i updated the PR according to the comments.