search

FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/
Apache License 2.0
13 stars 8 forks source link

Separate all the functionality from dataconverter to a reader utilities subpackge or module. #258

Open RubelMozumder opened 9 months ago

RubelMozumder commented 9 months ago

Contact Details

No response

What happened?

Move all the functionalities that are not directly involved to the dataconverter but rather used in readers e.g. extract_atom_types should move to the reader utils

What do you think here @domna, @lukaspie, @sherjeelshabih, @mkuehbach?

Relevant log output

No response

domna commented 9 months ago

I think we mostly keep it in the utils.py file already. But it's a good point to actually clean this up and offer this as a utils package also if people want to use it from their reader plugins.

RubelMozumder commented 9 months ago

I think we mostly keep it in the utils.py file already. But it's a good point to actually clean this up and offer this as a utils package also if people want to use it from their reader plugins.

you are suggesting having another python package only for reader utils?

domna commented 9 months ago

I think we mostly keep it in the utils.py file already. But it's a good point to actually clean this up and offer this as a utils package also if people want to use it from their reader plugins.

you are suggesting having another python package only for reader utils?

No, just as a sub-package to pynxtools, e.g., pynxtools.utils or so. Currently, it's in pynxtools.dataconverter.utils, which is probably also fine.