search

FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/
Apache License 2.0
12 stars 8 forks source link

Required fields under optional groups end up in required generated template #266

Closed sherjeelshabih closed 5 days ago

sherjeelshabih commented 4 months ago

This is discussed a bit in #257. Only fields that will break the reader's functionality if not provided should be displayed with the required flag in generate-template.

          When I use the `--required` flag it also reports fields which are under optional groups, which we should not output here. I would say that we should only require those which are strictly required.

Originally posted by @domna in https://github.com/FAIRmat-NFDI/pynxtools/issues/257#issuecomment-1959611191

lukaspie commented 5 days ago

@sherjeelshabih @domna where do we stand on this? Is this solved by the new nexus tree structure?

domna commented 5 days ago

@sherjeelshabih @domna where do we stand on this? Is this solved by the new nexus tree structure?

Yes, this is fixed with the new algorithm.