search

FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/
Apache License 2.0
12 stars 8 forks source link

Correctly use the extends keywords for applications definitions #35

Closed domna closed 5 days ago

domna commented 1 year ago

If an application definition uses the extends keyword the reader only checks the fields from the extending appdef and not the fields of the class which is extended. This should be supported ideally for base classes and application definitions.

There is a test in the branch https://github.com/nomad-coe/nomad-parser-nexus/tree/appdef_extends which checks the behaviour (currently failing test_inheritance).

lukaspie commented 5 days ago

Closed as completed by https://github.com/FAIRmat-NFDI/pynxtools/pull/339