search

FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/
Apache License 2.0
13 stars 8 forks source link

Removes unused CLI flags #373

Closed domna closed 4 months ago

domna commented 4 months ago

This removes the --documented and --fair flag from the dataconverter CLI. They are not used in the new validation and create wrong warnings if they are used. They are replaced by the new flag --ignore-undocumented for the new validation, which simply ignores all undocumented fields.

cc @rettigl

domna commented 4 months ago

The plugin tests for xps and mpes will probably fail because we exceeded our lfs quota.

domna commented 4 months ago

I also added the --fail keyword now. If the flag is given it fails raises an error and does not produce a file if validation problems are found. It will also exit with exit code 1 on the shell.

@rettigl: Is it fine like this?

rettigl commented 4 months ago

I also added the --fail keyword now. If the flag is given it fails raises an error and does not produce a file if validation problems are found. It will also exit with exit code 1 on the shell.

@rettigl: Is it fine like this?

Yes, excellent, thanks.