Enumerations not in appdef are not checked - Githubissues

FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/

Apache License 2.0

13 stars 8 forks source link

Enumerations not in appdef are not checked #434

Open rettigl opened 2 months ago

rettigl commented 2 months ago

The dataconverter does not check the validity of enumerations, if they are not part of the "nexus_tree" spanned by the application definition explicitly, I.e. for fields that are added from the base_class tree(s). This is handled here: https://github.com/FAIRmat-NFDI/pynxtools/blob/5f1cd3795bbd13b729fb192a7d89886ed3b2949a/src/pynxtools/dataconverter/validation.py#L589 and just continues if a field is documented, without checking if it contains valid data.

rettigl commented 2 months ago

@lukaspie Do you have a suggestion? Or is this by design?