FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/
Apache License 2.0
13 stars 8 forks source link

bump ruff to >v0.6 #454

Closed lukaspie closed 1 month ago

lukaspie commented 1 month ago

Same version as in NOMAD

rettigl commented 1 month ago

Also here: Linting CI/CD is still being run with ruff=0.5.5

lukaspie commented 1 month ago

Yeah, you are right, I didn't remember that we are actually installing the dev-requirements instead of doing uv pip install -e ."[dev]".

I updated the dev-requirements, now it should be okay

lukaspie commented 1 month ago

I was wondering, why don't we use get rid of the dev-requirements and simply do uv pip install ".[dev]"? We anyway install the package and its dev-requirements in the CI/CD. Any strong opinions @rettigl @RubelMozumder?