search

FAIRmat-NFDI / pynxtools

https://fairmat-nfdi.github.io/pynxtools/
Apache License 2.0
13 stars 8 forks source link

carefull name generation for new BasicELN archive and population NXroot #455

Closed sanbrock closed 1 month ago

sanbrock commented 1 month ago

I am not sure what exactly is now happening in lines 911-914 of src/pynxtools/nomad/schema.py. NXroot related parts look good to me.

Previously, the filename was constructed directly from lab_id. Since it can contain non-allowed characters (e.g. ':'), if it happens, a unique, but conform filename is generated here.

GinzburgLev commented 1 month ago

I am not sure what exactly is now happening in lines 911-914 of src/pynxtools/nomad/schema.py. NXroot related parts look good to me.

Previously, the filename was constructed directly from lab_id. Since it can contain non-allowed characters (e.g. ':'), if it happens, a unique, but conform filename is generated here.

I see; that makes sense now, thank you for the clarification.