FAIRsharing / domain-ontology

A project supporting the DRAO application ontology, a hierarchy of specific research domains and descriptors which imports subsets of terms from over 50 publicly-available ontologies.
Other
1 stars 1 forks source link

Refactor "Pathway or Network prediction" #75

Closed allysonlister closed 3 years ago

allysonlister commented 3 years ago

http://edamontology.org/operation_3439 (Pathway or network prediction) is now obsolete in EDAM.

Originally posted by @allysonlister in https://github.com/FAIRsharing/domain-ontology/issues/73#issuecomment-769198121

allysonlister commented 3 years ago

As described in the latest release of EDAM (you can see it at http://www.ontobee.org/ontology/EDAM?iri=http%3A%2F%2Fedamontology.org%2Foperation_3439), "Notions of pathway and network were mixed up, EDAM 1.24 disentangles them." EDAM suggests one of: Protein interaction network prediction; Metabolic pathway prediction; Gene regulatory network prediction

allysonlister commented 3 years ago

Although EDAM suggests the three classes mentioned in the previous comment, I find them to be far too specific to be useful as replacements for "pathway or network prediction". Rather, I suggest we replace this class with the more generic "Prediction and Recognition", as all if its child classes are too specific: predictrecog

There are currently 21 records annotated with this term, and I think this refactoring would work for them all. However, I also think that we should have a FAIRsharing preferred label so as not to confuse the EDAM prediction and recognition with more generic concepts. The EDAM definition is:

Predict, recognise, detect or identify some properties of a biomolecule.

And the term label implies something more generic than specifically about a biomolecule.

So, in summary:

Old IRI New IRI Note
http://edamontology.org/operation_3439 http://edamontology.org/operation_2423 Deprecation of EDAM term resulted in modification of the domain tag that is being used within DRAO. The new IRI already existed in FAIRsharing.

I'm really not sure about the third point though. Please would @delphinedauga and @Drosophilic provide their opinions on this suggestion as a whole, and the label specifically?

Thanks!

Drosophilic commented 3 years ago

Hi @allysonlister - this all sounds good. I'm not sure what you mean about your third point (operation_2423 is already visible in DRAO), but I follow your summary and it sounds the appropriate course of action.

delphinedauga commented 3 years ago

Hi @allysonlister ! I think it's a pity to lose "pathway or network prediction". One term in DRAO which is not too far away is "network model", but it's not really adapted for biology. Why not also add "Protein interaction network prediction"; "Metabolic pathway prediction"; "Gene regulatory network prediction" ? I don't find them too specific.

allysonlister commented 3 years ago

Thanks very much both of you!

Hi @allysonlister - this all sounds good. I'm not sure what you mean about your third point (operation_2423 is already visible in DRAO), but I follow your summary and it sounds the appropriate course of action.

The term suggested by EDAM as a possible replacement, http://edamontology.org/operation_2423 ("Prediction and recognition") already exists in DRAO with the FAIRsharing label of "Computational predictions". As such, this term (operation_2423) is already accessible to curation right now. This means I can re-curate the existing records now, in concert with the changes to DRAO.

Thanks again - I'll get started both on this and #74.

allysonlister commented 3 years ago

Sorry @delphinedauga I hadn't seen the second half of your comment. Here are my thoughts on your suggestion for adding things:

allysonlister commented 3 years ago

I've done all of the work initially planned for this ticket. I'll leave it open for @delphinedauga's reply to see if we should make any further modifications.

allysonlister commented 3 years ago

@delphinedauga has checked this modification.