FAIRsharing / fairsharing.github.io

The website for FAIRsharing, currently running at https://fairsharing.org.
https://fairsharing.org/
GNU Affero General Public License v3.0
8 stars 4 forks source link

Allow organisations to be downloaded in csv #2362 #2363

Closed knirirr closed 2 months ago

knirirr commented 3 months ago

This allows users to choose to include organisation information in a downloaded file.

Running it in a netlify build will require https://github.com/FAIRsharing/FAIRsharing-API/pull/1013 to be deployed on the development server, which is currently occupied by another branch.

allysonlister commented 2 months ago

Is this PR running properly at the moment? I tried downloading with organisations all polices, to test the timing (https://deploy-preview-2363--fairsharing.netlify.app/search?fairsharingRegistry=Policy) but there appears to be nothing happening after a few minutes.

Similar thing when I try a smaller query, e.g. https://deploy-preview-2363--fairsharing.netlify.app/search?q=multi%20omics

I'm on Firefox/ubuntu, though Chromium also appears to not be downloading.

thanks!

knirirr commented 2 months ago

@allysonlister https://github.com/FAIRsharing/FAIRsharing-API/pull/1013 needs to be dealt with first.

allysonlister commented 2 months ago

Ok I'll wait until you say before I check this ticket.

knirirr commented 2 months ago

It's ready - I have added you as a reviewer.

allysonlister commented 2 months ago

image This is what the downloaded content (the organisation columns) look like. The data itself looks correct, but note that the "Role" column is empty, and I'm not sure what would go there?

I suggest

Thanks!

knirirr commented 2 months ago

Somehow the data have become shifted along by a column. So, "type" is the type of organisation, and this is present but shifted left when it should be under the role column. These are all server-related changes I'll look at shortly.