search

FAIRsharing / subject-ontology

A project supporting the SRAO application ontology, a hierarchy of academic disciplines that imports subsets of terms from 7 publicly-available ontologies.
Other
6 stars 0 forks source link

Annotation (label) error for Synthetic Biology #25

Closed allysonlister closed 5 years ago

allysonlister commented 5 years ago

I have just noticed that I incorrectly added the "OMIT" annotation for the 'Synthetic Biology' class as a label rather than as an 'imported from' property. This is causing errors in the display of this tag within FAIRsharing. I suggest that I fix SRAO immediately and then release 0.1.1 to fix this bug and get it sorted within FAIRsharing. synbio

  1. @Drosophilic do you agree to the immediate fix of this issue and a 0.1.1 release? I didn't intend to release again so soon, but we should sort this out.
  2. Do you have any other issues in this tracker you would like to see sorted for the 0.1.1 release, if you say yes to point 1?

Thanks!

allysonlister commented 5 years ago

There is one other incidence of this in SRAO - with http://purl.obolibrary.org/obo/OMIT_0010508 (Neurophysiology). Not sure when these two issues happened, but they are manual problems and not to do with the import of annotation via Ontofox.

allysonlister commented 5 years ago

While compiling statistics, I noticed some other annotation issues. We should modify the erroneous importedFrom annotation for the following:

Should be comments (Hematology, Oncology, Transfusion Medicine; and Hepatics and Biliary Medicine):

AL: 28.9.17 'Hepatics and biliary medicine' is asserted as a child of Medicine within EDAM. This assertion has been further refined within FAIRsharing as a child of Gastroenterology.,1
"AL: 28.9.17 In future, it may be best to split this discipline into its constituent parts. For now, a child class has been created for each of the EDAM terms.",1

Should just read one or the other - not both (change AgroPortal to AgroPortal Categories?) see 'Agricultural and Food Process Engineering' and 'Farms and Farming Systems':

AgroPortal,1
AgroPortal Categories,1
allysonlister commented 5 years ago

Both of the AgroPortal Categories have been refactored to AgroVoc, and so the inconsistency above is no longer present. The labelling error has also been fixed, and therefore this issue can be closed.