FAST-HEP / fast-plotter

Manipulate binned pandas dataframes into plots
https://fast-hep.web.cern.ch
3 stars 8 forks source link

Fixes to 1D plotting #13

Closed benkrikler closed 5 years ago

benkrikler commented 5 years ago
benkrikler commented 5 years ago

Updated config file on demo repo: https://gitlab.cern.ch/fast-hep/public/fast_cms_public_tutorial/merge_requests/7

eshwen commented 5 years ago

As rootpy (and therefore ROOT) is now required to get proper ratio plots, the documentation/instructions should be updated to reflect that

benkrikler commented 5 years ago

As rootpy (and therefore ROOT) is now required to get proper ratio plots, the documentation/instructions should be updated to reflect that

Thanks, although ROOT was never intended to be a requirement. Only an optional dependency only needed by some functions, and with an appropriate warning printed when it's called.

In any case, in the latest version of this branch, when using with the command line interface, there's no dependency on ROOT at all.

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #13    +/-   ##
=====================================
  Coverage       0%    0%            
=====================================
  Files           5     6     +1     
  Lines         480   690   +210     
=====================================
- Misses        480   690   +210
Impacted Files Coverage Δ
fast_plotter/utils.py 0% <0%> (ø) :arrow_up:
fast_plotter/plotting.py 0% <0%> (ø) :arrow_up:
fast_plotter/__main__.py 0% <0%> (ø) :arrow_up:
fast_plotter/__init__.py 0% <0%> (ø) :arrow_up:
fast_plotter/statistics.py 0% <0%> (ø)