search

FAU-AMMN / fau-beamer

Beamer template according to the FAU corporate style guide 2021
35 stars 13 forks source link

Spacing corrections, mostly for empty/blank arguments #30

Closed aquileia closed 4 months ago

TimRoith commented 4 months ago

Thank you very much, looks good!

I don't completely understand the \adjustment command. Other than that, I'm ready to accept the PR.

aquileia commented 4 months ago

The second commit introduces the Package option AdjustTheme, which is passed through to beamerouterthemefau & beamerinnerthemefau. This allows a user to substitute some of the spacing values in the slide layout.

Usage example: There's two use cases I've encountered so far,

  1. enlarging the title area when the sub-/title contains formulae that would otherwise jut out
  2. compressing the title area when several slides consist of a single big plot/diagram that needs as much space as possible

Instead of resorting to hacking the values in the package itself, the AdjustTheme option provides a clean and visible way to do this:

\RequirePackage[institute=Tech, aspectratio=169,
            AdjustTheme={TitleHeight=25mm, TitleTitleSkip=2mm, TitleSkip=2mm},
            ]{styles/beamerthemefau}

Implementation details: The \adjustment command is just there as a buffer to save the value of AdjustTheme. \edef & \noexpand are necessary for delayed parsing, so that the value isn't treated as a text.

aquileia commented 4 months ago

I added a summary of the above description to the commit, and rebased the branch on FAU-AMMN:main so that merging won't create a merge commit. The actual code changes are untouched by this.

TimRoith commented 4 months ago

Ok thanks,

I was only reflecting, if it would have negative consequences, to basically allow redefining any command via this method and if one should, instead, explicitly expose these arguments. But I guess the solution you proposed is easier and more elegant than that and as far as I see it now, it would be up to the user to not break the package by redefining commands.

So thanks for the contribution.