FAU-CS6 / KDD

Lecture and exercise of "Knowledge Discovery in Databases"
GNU General Public License v3.0
22 stars 11 forks source link

Update lecture to summer semester 2023 #68

Closed melsigl closed 1 year ago

melsigl commented 1 year ago

Changes so far include, but may not limit to:

See also potential comments under this PR.

melsigl commented 1 year ago

@dominik-probst: Feel free to include any updates that you have from your side to this PR, or - alternatively - create a separate PR.

dominik-probst commented 1 year ago

@dominik-probst: Feel free to include any updates that you have from your side to this PR, or - alternatively - create a separate PR.

Since I still need a few days for my adjustments (and will also spread them over several weeks until the semester starts) it is probably better to start a separate PR for my adjustments.

dominik-probst commented 1 year ago

Since my planned SS23 changes have been finished since yesterday, I have taken the liberty of attaching them to this PR.

These changes are primarily:

In the course of today I have also added the following changes to this PR:

Since I already reviewed your changes (including yesterday's schedule change) and found them to be good, I would now ask you to review my changes @melsigl .

Since I made the introduction of the table of contents and the task numbering in your two exercises without consultation with you, I have also indicated the commit here in each case, so that you can easily undo these changes, should they not have been in your interest.

melsigl commented 1 year ago

Thank you, @dominik-probst, for your effort to update our lecture slides and our exercises.

Your changes sound valid to me even though I had not the luxury to invest the time it deserves to read every change in all its detail. However, I have some (minor) notes:

Exercises:

Lectures:

I also had to add a fix to the classification exercise involving Naive Bayes.

All in all, consider my consent to approve & merge as I cannot change the reviewer to myself and merge without bypassing our branch protection.

dominik-probst commented 1 year ago

Thank you @melsigl for the review.

I have just implemented your advice on the __str__ functions.

The suggestion regarding the footnotes will be implemented somewhere in the future (Issue #69).

After the checks have been run, I will merge this PR.