search

FAU-LAP / NOMAD-CAMELS

We are developing a configurable measurement software (CAMELS), targeted towards the requirements of experimental solid-state physics. Here many experiments utilize a multitude of measurement devices used in dynamically changing setups.
https://fau-lap.github.io/NOMAD-CAMELS/
GNU Lesser General Public License v2.1
13 stars 3 forks source link

Hard-coded paths of developer's PC? #66

Closed ktahar closed 8 months ago

ktahar commented 8 months ago

Part of JOSS review: https://github.com/openjournals/joss-reviews/issues/6371

I found a HDF5 in repository root: C--Users-od93yces-NOMAD_CAMELS_data-default_user-sadf-data_2024-01-25T13-54-39.800814%2B01-00.hdf5. What is this for?

And some paths (C:\Users\od93yces...) are hard-coded, which looks like something in a developer's PC. I think these should be removed.

Jo-Leh commented 8 months ago

These paths were added with some new parts of the code. Thanks for spotting them! I forgot to take them out. The hdf5 file as well. All of these will be removed, currently on https://github.com/FAU-LAP/NOMAD-CAMELS/tree/development