FBDevCLagos / hiddenwisdom-react-js

Hidden Wisdom Front End Project
MIT License
4 stars 0 forks source link

Feature/#16/proverbs crud #33

Closed heyolajyd closed 7 years ago

akinjide commented 7 years ago

@andela-Jaderibigbe can we fix all this comments, and also make the test pass and the conflict

heyolajyd commented 7 years ago

@andela-abankole Cool. I will fix the tests. This hound bot is really cool :)

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-18.9%) to 69.108% when pulling 6bb2c5c4af9ead73ebc6b4d32615d88bf49b3d49 on feature/#16/proverbs-CRUD into 71e6dda98e12620af5a7eaf38b19dc8bf4e5bcc6 on develop.

akinjide commented 7 years ago

Cool, Can we work on the conflict as well

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-11.09%) to 76.913% when pulling 122038f10933f763f660061230fdef6e990984f7 on feature/#16/proverbs-CRUD into 71e6dda98e12620af5a7eaf38b19dc8bf4e5bcc6 on develop.

innocentamadi commented 7 years ago

What? Decreased coverage by 11.09%? Jyd what have you done?? 😀

On Sep 16, 2016, at 6:56 PM, Coveralls notifications@github.com wrote:

https://coveralls.io/builds/7924585 Coverage decreased (-11.09%) to 76.913% when pulling 122038f https://github.com/lagos-devs/hiddenwisdom-react-js/commit/122038f10933f763f660061230fdef6e990984f7 on feature/#16 https://github.com/lagos-devs/hiddenwisdom-react-js/issues/16/proverbs-CRUD into 71e6dda https://github.com/lagos-devs/hiddenwisdom-react-js/commit/71e6dda98e12620af5a7eaf38b19dc8bf4e5bcc6 on develop.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lagos-devs/hiddenwisdom-react-js/pull/33#issuecomment-247665831, or mute the thread https://github.com/notifications/unsubscribe-auth/AL0V2aTvczIAjNeupl4eqZ2CcGNyoxLmks5qqthQgaJpZM4J-aWW.

heyolajyd commented 7 years ago

@andela-iamadi Can you point me to why coveralls coverage is failing?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-10.2%) to 77.821% when pulling b19bba17862964a740b04f8f2f7ced8d93f66866 on feature/#16/proverbs-CRUD into 71e6dda98e12620af5a7eaf38b19dc8bf4e5bcc6 on develop.

akinjide commented 7 years ago

@andela-Jaderibigbe how's the coverage test coming?