FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
64 stars 40 forks source link

πŸ› Sparsity thresholds not scaling for network centrality #2000

Closed shnizzedy closed 8 months ago

shnizzedy commented 1 year ago

Describe the bug

Updated string parameters from to
[…] […]
'sparsity' 'Sparsity threshold'

― https://github.com/FCP-INDI/C-PAC/pull/1396

https://github.com/FCP-INDI/C-PAC/blob/a8928461adc3dfc5c15b2aee6ead5be1bec54eca/CPAC/pipeline/schema.py#L83-L84

"sparsity" isn't a valid "threshold_option" since < 1.8.0, but that's the value used to scale the threshold value

https://github.com/FCP-INDI/C-PAC/blob/a0e425dd66a51743452c42b0c17c4ba24c38e3b0/CPAC/network_centrality/pipeline.py#L47-L49 https://github.com/FCP-INDI/C-PAC/blob/3facedbfbc81e581e556baf280b3421d76622e6c/CPAC/network_centrality/network_centrality.py#L72-L73

Expected behavior

The scaling occurs for 'Sparsity threshold' instead of for 'sparsity' or the threshold range is 0 β€’ 100 instead of 0 β€’ 1 for 'Sparsity threshold'

Acceptance criteria

C-PAC version

1.8.0 β€’ 1.8.5

Additional context

Discovered while working on https://github.com/FCP-INDI/C-PAC/pull/1998

shnizzedy commented 1 year ago

Anthem for the Year 2000

shnizzedy commented 8 months ago

Fixed in 1.8.6