Closed shnizzedy closed 8 months ago
Updated string parameters from to [β¦] [β¦] 'sparsity' 'Sparsity threshold'
β https://github.com/FCP-INDI/C-PAC/pull/1396
https://github.com/FCP-INDI/C-PAC/blob/a8928461adc3dfc5c15b2aee6ead5be1bec54eca/CPAC/pipeline/schema.py#L83-L84
"sparsity" isn't a valid "threshold_option" since < 1.8.0, but that's the value used to scale the threshold value
"sparsity"
https://github.com/FCP-INDI/C-PAC/blob/a0e425dd66a51743452c42b0c17c4ba24c38e3b0/CPAC/network_centrality/pipeline.py#L47-L49 https://github.com/FCP-INDI/C-PAC/blob/3facedbfbc81e581e556baf280b3421d76622e6c/CPAC/network_centrality/network_centrality.py#L72-L73
The scaling occurs for 'Sparsity threshold' instead of for 'sparsity' or the threshold range is 0 β 100 instead of 0 β 1 for 'Sparsity threshold'
'Sparsity threshold'
'sparsity'
1.8.0 β 1.8.5
Discovered while working on https://github.com/FCP-INDI/C-PAC/pull/1998
Fixed in 1.8.6
1.8.6
Describe the bug
β https://github.com/FCP-INDI/C-PAC/pull/1396
https://github.com/FCP-INDI/C-PAC/blob/a8928461adc3dfc5c15b2aee6ead5be1bec54eca/CPAC/pipeline/schema.py#L83-L84
"sparsity"
isn't a valid "threshold_option" since < 1.8.0, but that's the value used to scale the threshold valuehttps://github.com/FCP-INDI/C-PAC/blob/a0e425dd66a51743452c42b0c17c4ba24c38e3b0/CPAC/network_centrality/pipeline.py#L47-L49 https://github.com/FCP-INDI/C-PAC/blob/3facedbfbc81e581e556baf280b3421d76622e6c/CPAC/network_centrality/network_centrality.py#L72-L73
Expected behavior
The scaling occurs for
'Sparsity threshold'
instead of for'sparsity'
or the threshold range is 0 β 100 instead of 0 β 1 for'Sparsity threshold'
Acceptance criteria
'Sparsity threshold'
instead of for'sparsity'
or'Sparsity threshold'
C-PAC version
1.8.0 β 1.8.5
Additional context
Discovered while working on https://github.com/FCP-INDI/C-PAC/pull/1998