👷 CI tries to launch duplicate ACCESS runs with current triggers - Githubissues

FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes

https://fcp-indi.github.io/

GNU Lesser General Public License v3.0

64 stars 40 forks source link

👷 CI tries to launch duplicate ACCESS runs with current triggers #2005

Open shnizzedy opened 11 months ago

shnizzedy commented 11 months ago

Describe the bug

These triggers https://github.com/FCP-INDI/C-PAC/blob/de6407454d35e0cbf0434f7bc34fe44b924e2819/.github/workflows/regression_test_lite.yml#L3-L17 lead to duplicate run attempts and this conditional https://github.com/FCP-INDI/C-PAC/blob/de6407454d35e0cbf0434f7bc34fe44b924e2819/.github/workflows/regression_test_lite.yml#L40 intended to prevent this behavior is not preventing it.

To reproduce

Open a pull request.
See two runs attempt.

Expected behavior

0 or 1 ACCESS runs is attempted on PRs

- opened 
- ready_for_review 
- reopened

coming from branches or forks and targeting develop

Acceptance criteria

[ ] At most 1 ACCESS run is attempted

Screenshots

"marked this pull request as ready for review 8 minutes ago" Actions Triggered via pull_request Triggered via pull_request_target

Additional context

As an alternative to these triggers, we could trigger after the changes are merged into develop