FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
64 stars 40 forks source link

👔 Make CCS & fMRIPrep BOLD masking steps interchangeable #2014

Closed shnizzedy closed 11 months ago

shnizzedy commented 11 months ago

Fixes

Fixes

LookupError: When trying to connect node block 'coregistration_prep_fmriprep' to workflow 'cpac_sub-NDARINV2VY7YYNW_ses-baselineYear1Arm1' after node block 'func_normalize': 

[!] C-PAC says: None of the listed resources in the node block being connected exist in the resource pool.

Resources:
['desc-ref_bold']

for

functional_preproc:
  func_masking:
    using:
      - CCS_Anatomical_Refined
registration_workflows:
  functional_registration:
    coregistration:
      func_input_prep:
        input:
          - fmriprep_reference

by @nx10 & @e-kenneally on Slack

Description

Updates the BOLD resource coming out of the bold_mask_ccs NodeBlock to be interchangeable with the BOLD resource coming out of the bold_mask_fsl_afni NodeBlock. (The BOLD resource coming out of bold_mask_ccs is not being used elsewhere as far as I can tell)

Technical details

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
sgiavasis commented 11 months ago

The nature of the original CCS pipeline (stop and check/choose masks) doesn't fully jive with C-PAC's automated "industrial scale", so we do need to reassess the CCS options at some point based on intended use/strategy. But this is good for now!