FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
64 stars 40 forks source link

Prevent Nipype from emitting .proc-* files to user working dir Fix #1955 #2030

Closed nx10 closed 9 months ago

nx10 commented 9 months ago

Fixes

Fixes #1955 by @amygutierrez

Description

Technical details

@shnizzedy 's exhaustive internal writedown 🕵️

C-PAC and fMRIPrep both hit the issue upgrading from nipype 1.5.x to 1.8.x; I think this chdir that used to be before initializing the ResourceMonitor led to this relative path being inside the relevant subdirectory of the working directory, but now it's initialized without changing directories first

Tests

Screenshots

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
shnizzedy commented 9 months ago

This means they will automatically be cleaned if the working dir is not retained (no --save-work-dir)

and that they'll be in their respective subdirectories of the working directory if the working dir is retained!