FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
64 stars 40 forks source link

fslrobustfov with padding inorder to remove neck regions in the fsl-bet skull stripped image #2035

Closed birajstha closed 9 months ago

birajstha commented 9 months ago

Fixes #1928

Fixes #1928 by @birajstha

Description

This PR further expands the work of former cpac developer @tergeorge, by addressing the bug on implementation of RobustFOV. RobustFOV crops the Nifti Image and hence when BET generates the mask, the mask doesnot match the dimension of the original resampled image thus giving error in "3Dcalc" down the pipeline.

Tests

Tested on few (4-5) sample datasets with and without neck regions in the image where it performed as expected.

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
shnizzedy commented 9 months ago

I rebased both sides of this PR so this PR will include just the relevant commits and won't include all the changes in develop since last March when this branch was originally created from main, and I went ahead and did a conflict resolution on the resulting comparison