Mask boolean default on

birajstha commented 8 months ago

Fixes

Fixes #2052 by @sgiavasis

Description

Hard-coded the -m flag in the FSL BET block.
The mask_boolean keys in all of the configs are removed.

Technical details

Tests

Run one of the config and check to see working directory to see if mask image is there inside the anat_BET_skullstrip folder

Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the develop branch of the repository.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[x] I updated the changelog.
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

sgiavasis commented 8 months ago

Re: @shnizzedy - we can remove it from randomise yes.

Also reminder @birajstha to please update the changelog.

shnizzedy commented 8 months ago

Oh, I also think you can do like

git fetch origin
git checkout origin/develop -- .github/Dockerfiles/*.Dockerfile

and add and commit those changes to fix the merge conflicts. They're just parallel version comment updates

FCP-INDI / C-PAC