FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
61 stars 39 forks source link

⚰️ Remove dead code (`create_fsl_model`) #2078

Closed shnizzedy closed 3 months ago

shnizzedy commented 3 months ago

Fixes

Fixes https://github.com/FCP-INDI/C-PAC/pull/2063#issuecomment-1970073394 by @shnizzedy & @sgiavasis

Description

CPAC/utils/create_fsl_model.py seems dead? That file has lots of issues and is not imported anywhere as far as I can tell

It's no longer actively supported. I don't know if FSL style group-level analysis is still in vogue but if we're gonna ever revive it, it will be in a separate group-level package+container. So, save it somewhere I guess but we don't need it in the container anymore, no.

I think it'll be easy enough to find in the repo if/when we need it later since we talk about removing it here and in #2063.

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```