FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
61 stars 39 forks source link

⏪️ Revert file mode changes from 9e9503d26 & 21911eacf #2101

Closed shnizzedy closed 2 months ago

shnizzedy commented 2 months ago

Related to

Related to #2100 by @sgiavasis

Description

Reverts two file mode 644 → 755 changes from the 1.8.7 development cycle.

Technical details

As of ff57b3f4936c71198b9b33737181e20afe0a6718, 3 files have their modes changed from rw-r--r-- to rwxr-xr-x.

CPAC/utils/configuration/yaml_template.py has https://github.com/FCP-INDI/C-PAC/blob/16320b95f67dbbcb8eb4a1e73cc99182d5e769c0/CPAC/utils/configuration/yaml_template.py#L499-L500 and was made executable in #2072 for pre-commit to execute that script.

The other two files don't have if __name__ == "__main__": fences or any top-level code besides imports and definitions, so I think the additional executable mode change was in error and is reverted here.

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```