FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
61 stars 39 forks source link

⚰️ Remove stale variants #2115

Closed shnizzedy closed 1 month ago

shnizzedy commented 1 month ago

Related to

Related to #1987 by @sgiavasis Related to #2110 by @shnizzedy

Description

The version-matched C-PAC variant images have been dragged along with each C-PAC version since they were introduced, which gets us C-PAC improvements in these images but also brings increasing technical debt with each release.

This PR drops the variants (besides the FreeSurfer-less lite variant) from each release, with the intent of occasionally reharmonizing with fMRIPrep and ABCD-HCP and releasing dependency-matched variant images each time we reharmonize.

Technical details

By dropping these stale variants, we no longer need to support Python < 3.10, so this PR also removes the special handling for typehinting in Python 3.7‒3.9.

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```