FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
61 stars 39 forks source link

📦️ Restore `bids-validator` installation in containerized C-PAC images #2120

Closed shnizzedy closed 3 weeks ago

shnizzedy commented 4 weeks ago

Fixes

Fixes #2110 by @shnizzedy Related to [comment] by @shnizzedy (response to Neurostars Running an older version of C-PAC (V1.3.0) by @Ammar_Ibrahim)

Description

In looking into the issue, I discovered that we inadvertently removed the bids-validator CLI, so trying to run with the BIDS validator in versions 1.8.6 and 1.8.7 will fail as well.

Neurostars Re: Running an older version of C-PAC (V1.3.0)

This PR

  1. installs n https://github.com/FCP-INDI/C-PAC/blob/0232e722ab7078e4c9998b430321e30d483cac4d/.github/Dockerfiles/Ubuntu.jammy-non-free.Dockerfile#L67 and the Node.js version of bids-validator https://github.com/FCP-INDI/C-PAC/blob/0232e722ab7078e4c9998b430321e30d483cac4d/.github/Dockerfiles/Ubuntu.jammy-non-free.Dockerfile#L32 https://github.com/FCP-INDI/C-PAC/blob/0232e722ab7078e4c9998b430321e30d483cac4d/.github/Dockerfiles/Ubuntu.jammy-non-free.Dockerfile#L68
  2. Adds bids-validator to the list of dependencies to log the version of https://github.com/FCP-INDI/C-PAC/blob/0232e722ab7078e4c9998b430321e30d483cac4d/CPAC/utils/versioning/dependencies.py#L139-L144

Technical details

Tests

https://github.com/FCP-INDI/C-PAC/blob/0232e722ab7078e4c9998b430321e30d483cac4d/CPAC/utils/tests/test_bids_utils.py#L77-L79 (fails when bids-validator CLI is not installed)

Screenshots

python /code/CPAC/__main__.py version

`bids-validator: 1.14.6`

bids-validator --help

`Usage: bids-validator <dataset_directory> [options]`

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```