search

FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes
https://fcp-indi.github.io/
GNU Lesser General Public License v3.0
64 stars 41 forks source link

cpac_run.py shouldn't need wx #441

Closed alexsavio closed 9 years ago

alexsavio commented 9 years ago

AFAIK, C-PAC is a tool run exclusively through python and command line. The GUI is an extra feature to help building the configuration files.

Why do you make wxPython a hard dependency? If I wanted to run C-PAC in a cluster, I shouldn't need to install an unnecessary GUI library in it.

Maybe I'm wrong and you do need wx. Could you please clear this to me?

Thank you very much for the hard work!

jpellman commented 9 years ago

Hi Alexandre,

C-PAC was designed to be easy to use for researchers who otherwise might not have extensive programming/technical experience. Hence, the GUI is an integral part of the package, which is why wxPython is a hard dependency. It is not intended to be used strictly via the command line, although it can be executed in this manner if desired.

Best, John Pellman

alexsavio commented 9 years ago

Thanks John. I've just removed 'GUI' from CPAC/init.py. It wouldn't be complicated to make this optional anyway.

Cheers, Alex

danlurie commented 9 years ago

Can we re-open this? When we transitioned to the GUI and began requiring WX, my understanding was that we would eventually re-enable the ability to run entirely from the command line, which is a really important feature for a lot of people (including me).

Maybe @alexsavio can do a pull request for this modification and we can add this as an option in a future release (or at least document the workaround on the User Guide).

alexsavio commented 9 years ago

Sorry, I closed this, but if you agree I can start doing it.

jpellman commented 9 years ago

Hi Alex and Dan,

We're about to do a code freeze after the release of C-PAC 0.3.9, followed by an extensive and much-needed code re-factoring. At this time, we would thus prefer not to make any major changes to the C-PAC codebase, although our developers can take into account the possibility of decoupling the GUI from the YAML-based modules during the re-factoring. As Alex said, it shouldn't be too difficult once we've decided how to tackle re-factoring.

sgiavasis commented 9 years ago

CPAC can still be run from only the command line. If anything, this may be more of a documentation issue regarding how the YAML files can be hand-edited appropriately with the advent of new options and encodings.

alexsavio commented 9 years ago

Yes, of course. If you edit the code and remove the GUI submodule. :)

Alexandre Manhães Savio
PhD, Medical Imaging, Machine Learning Grupo de Inteligencia Computacional UPV/EHU home | email: alexsavio@gmail.com

From: sgiavasis notifications@github.com Reply: FCP-INDI/C-PAC reply@reply.github.com> Date: 11 Feb 2015 at 22:54:02 To: FCP-INDI/C-PAC c-pac@noreply.github.com> Cc: Alexandre M. S. alexsavio@gmail.com> Subject:  Re: [C-PAC] cpac_run.py shouldn't need wx (#441)

CPAC can still be run from only the command line. If anything, this may be more of a documentation issue regarding how the YAML files can be hand-edited appropriately with the advent of new options and encodings.

— Reply to this email directly or view it on GitHub.

sgiavasis commented 9 years ago

Yes - but beyond the unnecessary wx import invoked through init, the makeup of the system is still so that at the heart of it all, CPAC can be run with one function.

We're coming up with a way to bypass the GUI call if wx is not available, and this will be implemented in 0.3.9. Thanks for the report!

alexsavio commented 9 years ago

Yes, I know. I used it some time ago before you had the GUI.

I pushed the Condor job submission code (I don’t know if still works, btw)

Thanks,

Alexandre Manhães Savio
PhD, Medical Imaging, Machine Learning Grupo de Inteligencia Computacional UPV/EHU home | email: alexsavio@gmail.com

From: sgiavasis notifications@github.com Reply: FCP-INDI/C-PAC reply@reply.github.com> Date: 11 Feb 2015 at 23:00:05 To: FCP-INDI/C-PAC c-pac@noreply.github.com> Cc: Alexandre M. S. alexsavio@gmail.com> Subject:  Re: [C-PAC] cpac_run.py shouldn't need wx (#441)

Yes - but beyond the unnecessary wx import invoked through init, the makeup of the system is still so that at the heart of it all, CPAC can be run with one function.

We're coming up with a way to bypass the GUI call if wx is not available, and this will be implemented in 0.3.9. Thanks for the report!

— Reply to this email directly or view it on GitHub.

pintohutch commented 9 years ago

I made this fix in commit https://github.com/FCP-INDI/C-PAC/commit/9e27274a7c667adfc10346604bd2fedeafb5eb17. This will be in the 0.3.9 release