FCP-INDI / cpac

A convenience wrapper for https://github.com/FCP-INDI/C-PAC that provides a simple command line interface.
https://fcp-indi.github.io/docs/latest/user/cpac
MIT License
4 stars 3 forks source link

👽️ Upgrade to handle changes in C-PAC, Python and Mac OS #36

Closed shnizzedy closed 1 year ago

shnizzedy commented 1 year ago

Fixes

Fixes #21 by @keithcdodd Fixes #35 by @neurosurd

Description

Re: #21

If cpac can't bind an absolute path, now it will bind that path relative to the current working directory. For example, if a config wants to bind /logs:/logs but is not permitted to, cpac will bind ${PWD}/logs:/logs instead and print a warning like

Could not create /logs. Binding /logs to /path/to/current_directory/logs instead.

Re: #35

Removes the pre-selection of the default pipeline

Tests

Checklist

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
coveralls commented 1 year ago

Coverage Status

Coverage: 62.365% (-2.05%) from 64.415% when pulling 53a4af4b14b6b2eb1686d6ae392bdf2017478257 on cpac_resources into 895bad33d4b82165c408babf14f845d6048ddf3c on develop.