FCS-analysis / PyCorrFit

data analysis and fitting software for fluorescence correlation spectroscopy (FCS)
pycorrfit.craban.de
Other
45 stars 13 forks source link

Solving bug #179 #182

Closed toubol closed 6 years ago

toubol commented 6 years ago

Solving export problem (#179):

codecov-io commented 6 years ago

Codecov Report

Merging #182 into develop will decrease coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    27.19%   27.15%   -0.04%     
===========================================
  Files           82       82              
  Lines        10192    10207      +15     
===========================================
  Hits          2772     2772              
- Misses        7420     7435      +15
Impacted Files Coverage Δ
pycorrfit/gui/plotting.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3d0fae...687b600. Read the comment docs.

paulmueller commented 6 years ago

Thanks for the great fix! Is it really necessary to go through the additional for-loop? I would prefer something like

text += genLatexText(parms, labels)

and then join all the strings in genLatexText (without the yield statement) and return them as a whole.

toubol commented 6 years ago

No, it is not needed, it was just on my personal convenience. You can easy initialise a tmpstr = r"" statement before the loop. Then concatenate after each iteration tmpstr += line and finally return this tmpstr to get the same type of statement you asked for.