search

FCare / Kronos

Kronos is a Sega Saturn emulator.
http://fcare.github.io
237 stars 23 forks source link

Kronos 1.5.0 Upscaling Issues #341

Closed LuismaSP89 closed 4 years ago

LuismaSP89 commented 6 years ago

Various upscaling issues in kronos 1.5.0 (2x, 4x, 8x or 16x) tested versus 4x resolution of Yaba Sanshiro v2.2.0 and all works ok (The 4x resolution is used in the images of this thread: https://github.com/FCare/Kronos/issues/181)

Here it is the kronos 1.5.0 in 8x resolution with artifacts (Artifacts appear in all resolutions):

3 1 2

LuismaSP89 commented 6 years ago

Update: With the last build of https://github.com/FCare/Kronos/issues/338 this looks a bit better (not perfect) in shining force. Deep fear looks the same.

Some examples:

deep fear shining shining 2

BenjaminSiskoo commented 6 years ago

@LuismaSP89 Hola/Oi can you test this exe :
kronos.zip

LuismaSP89 commented 6 years ago

@BenjaminSiskoo No changes, the upscaling issue persist, maybe it looks a very tiny better in deep fear. The only change is that now the embellishment filters shows no more the artifacts of https://github.com/FCare/Kronos/issues/339 , in fact the filters doesn´t work (All of them = none enabled)

Edit: It seems that solves https://github.com/FCare/Kronos/issues/340 when the Tesselation is enabled, good news, one less problem ; )

Tatsuya79 commented 6 years ago

Probably the same kind of issue I noticed, comparing Kronos on windows and the RetroArch core vs uoYabause. In Sega Rally plus some edges are cut, like on each border of the road.

Kronos (RA current core, same in stand-alone 1.5): sega_rally_championship_plus-ra

uoYabause (2.2): uoyabause

2x/4x (and 8x for RA) shows the same problem. Perspective or tessellation have no impact.

barbudreadmon commented 6 years ago

The issue in Sega Rally Plus started with https://github.com/FCare/Kronos/commit/1c1755b5d9f35c4e205a6cd20a70eb5ffd64db5b

It makes sense since it is a commit about polygon lines.

FCare commented 6 years ago

Yes, I found the same :-) I am working on it. The global root cause of these issues are due to the way the saturn is filling quads which is different from the openGL. I am trying to get a better fill but it is not really easy to get the right behavior without side effects... I hope I will be able to share some patches next week.

LuismaSP89 commented 6 years ago

It seems that there´s a different issue then, since the upscaling problems with other games like shining force 3 or deep fear are from long ago (Tested with kronos 1.2.0 and 1.3.0 with 2x Interal res and looks the same) and like I said, in Yaba Sanshiro v2.2.0 at 4x IR works ok.

LuismaSP89 commented 5 years ago

Updated with current build from 10th Jan 2019 -

sin titulo2 sin titulo

LuismaSP89 commented 4 years ago

Update in this issues with Kronos 2.1.0:

All issues remain and in some cases becomes worse. Some images attached. Testing various video backends/options:

Deep fear, using OpenGL and real BIOS: 1

Shining force 3, using OpenGL and real BIOS: 2

Deep fear, using compute shaders backend and real BIOS: Compute shaders

Deep fear, using OpenGL and emulated BIOS: Emulated bios

LuismaSP89 commented 4 years ago

Seems that all this upscaling issues are no longer present in Kronos 2.1.2 because of the graphics backend revert.

Only remaining issue for deep fear is the annoying sound "like a choppy TV snow"

https://github.com/FCare/Kronos/issues/556

Closing this and other related issues.