Adding Fedora (33) support, fixing sudo make install

FD- / RPiPlay

An open-source AirPlay mirroring server for the Raspberry Pi. Supports iOS 9 and up.

GNU General Public License v3.0

4.93k stars 353 forks source link

Adding Fedora (33) support, fixing sudo make install #185

Closed ninjaz5736 closed 3 years ago

ninjaz5736 commented 3 years ago

Fixes #182 - mentions plist-2.0 in lib/CMakeLists.txt
Update README to show Fedora 33 Instructions
Change install target in (root/)CMakeLists.txt to point to build directory, enabling successful sudo make install
Update README to include mention of sudo make install

I haven't been able to test anything on other distributions so I can't say I haven't broken anything, but it shouldn't have!

pallas commented 3 years ago

The first two look great, thanks! The last one breaks my install command.

pallas commented 3 years ago

I already merged the other two. For the install thing, I typically build in-tree (yeah, yeah, I know) but let me try an out of tree build and see what changes. Do you have additional CMAKE stuff in your env? What version of cmake are you using?

ninjaz5736 commented 3 years ago

Ahh that would make sense, the instructions say have it done inside the build directory so that's probably why there's the mismatch. I'm using cmake version 3.18.4 on Fedora 33 Workstation (64-bit), no variables in my env AFAIK, I only installed cmake a few days ago for another unrelated project! I've just tried an in-tree build and it works flawlessly, so probably just needs either documentation or that file updating :-)

pallas commented 3 years ago

Ok, I see the problem. Fixed upstream.