Closed Zenexer closed 3 years ago
aizvorski/h264bitstream is an upstream library, & while I'm open to accepting compiler lint patches I'd prefer if they were upstream first and we just integrated a real release. For this particular package, I found a bunch of problems with in via fuzzing and I turn it off in my own build.
https://github.com/FD-/RPiPlay/blob/e485668f752cedf9d1304ca08d5b2f2d03b67063/renderers/h264-bitstream/h264_sei.c#L686-L687
Only the first statement will be looped here (
printf("%ld.%d: ", (long int)(b->p - b->start), b->bits_left);
). Considering the following statements referencei
, this is almost certainly undesirable.This is reported as a warning by GCC (
misleading-indentation
):