FDM-UARuhr / rdmo-catalog-uaruhr

Host of RDMO catalogs developed by FDM-UARuhr.
https://fdm-uaruhr.github.io/rdmo-catalog-uaruhr/
Creative Commons Zero v1.0 Universal
2 stars 4 forks source link

wrong attributes in yaml file #69

Closed ClaraRosalie closed 3 years ago

ClaraRosalie commented 3 years ago

Describe the bug The file cat_member.yaml contains two question paths attributes that do not exist in UA Ruhr-catalog (on rdmo-demo):

Additionally there is one attribute which references a question set rather than a question:

jmfrenzel commented 3 years ago

The file https://github.com/FDM-UARuhr/rdmo-catalog-uaruhr/blob/master/tools/cat_member.yaml references <path>variables of questions and not the <attributes>.

The ua_ruhr/content-classification/data-reuse``<path> variable references to a questionset. The path variables of questionsets are not needed in https://github.com/FDM-UARuhr/rdmo-catalog-uaruhr/blob/master/tools/cat_member.yaml and this entry can be deleted, though it does not have any implications on the catalog creation via https://github.com/FDM-UARuhr/rdmo-catalog-uaruhr/blob/master/tools/auto_catalog_creation.py see #70

ClaraRosalie commented 3 years ago

Path variable ua_ruhr/metadata-and-referencing/metadata/abstract cannot be found on rdmo-demo, but there is a similar variable ua_ruhr/metadata-and-referencing/metadata-dataset/abstract. Is this also due to the newer version https://github.com/FDM-UARuhr/rdmo-catalog-uaruhr/releases/tag/1.1.0-beta.1?

jmfrenzel commented 3 years ago

The file https://github.com/FDM-UARuhr/rdmo-catalog-uaruhr/blob/master/tools/cat_member.yaml references <path>variables of questions and not the <attributes>.

* Therefore `ua_ruhr/metadata-and-referencing/metadata/abstract` is a valid  `<path>`variable.

Correction: ua_ruhr/metadata-and-referencing/metadata/abstract is not used in any rdmo catalog and therefore can be removed.

Thanks @ClaraRosalie for spotting this.